Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for timezones #539

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ngsilverman
Copy link

@ngsilverman ngsilverman commented Jan 29, 2024

I noticed that the displayed time of some of my events were off. This has gone through minimal testing but it fixed the events I was looking at, so hopefully it goes in the right direction even if it may not yet work in all cases.

This approach uses the timezone information from ICS to properly convert ical.Time objects to UTC, from there it uses the local timezone to convert those into accurate dates and times for human consumption.

TODO

  • Update tests: I tried updating the snapshots but since the current change uses the local timezone something needs to be figured out to make the tests consistent. Probably the tests should be based on UTC and the local timezone conversion can happen separately.

Possibly Related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant