Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for issue #311 #527

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fcortell
Copy link

Added ical-expander to help calendar get more info about timezones.

Copy link
Collaborator

@davish davish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting @fcortell! I had a few early questions before testing this out.

package.json Outdated Show resolved Hide resolved
src/calendars/parsing/ics.ts Outdated Show resolved Hide resolved
@fcortell fcortell closed this Dec 18, 2023
@fcortell fcortell reopened this Dec 18, 2023
@fcortell
Copy link
Author

Requested changes commited.

@davish
Copy link
Collaborator

davish commented Dec 20, 2023

Thank you @fcortell! Would you be able to add some unit tests to confirm that timezones are working as expected? Some tests that would be useful given issues that users have had in the past:

  • Event in GMT, user in a non-UTC timezone (e.g. Americas/New_York)
  • Instance of a Rrecurring event scheduled before daylight savings, after daylight savings
  • Event in Americas/New_York, user in a UTC timezone or a UTC+1 timezone
  • Event/user in Indian Standard Time (UTC+5:30)

These could be snapshot-based tests that live in src/calendars/parsing/ics.test.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants