Skip adding remote duplicate events #470
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adzcai
force-pushed
the
skip-not-throw
branch
from
6408285
to
c139faf
Compare
|
I can confirm this fixed work For anyone blocked on this and waiting for this PR to merged you can get it working by doing...
|
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A naive attempt to address #446.
When revalidating remote calendars, if an event with an ID already in the cache is found, just skip it.
This occurs after the events in the calendar are deleted, so naively I don't think this will run into concurrency issues, but I'd be grateful for somebody to think through it more carefully!