Add trace query RBAC #789
Open
Add trace query RBAC #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
force-pushed
the
trace-rbac
branch
from
6740db9 to
84b9bcd
Compare
pavolloffay
force-pushed
the
trace-rbac
branch
2 times, most recently
from
e7a5666 to
c22d039
Compare
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
force-pushed
the
trace-rbac
branch
from
c22d039 to
15cd838
Compare
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
| matchersTyped := matchers.(AuthzResponseData) | ||
|
|
||
| var namespaces []string | ||
| for _, m := range matchersTyped.Matchers { |
There was a problem hiding this comment.
Does matchersTyped.Matchers always contain a list of |-separated namespace names?
It's not directly related to this PR, but I wonder why the attribute is called Matchers and not Namespaces.
| } | ||
| level.Debug(log).Log("AllowedNamespaces", allowedNamespaces) | ||
|
|
||
| if strings.Contains(response.Request.URL.Path, "/api/traces/") || strings.Contains(response.Request.URL.Path, "/api/search") { |
There was a problem hiding this comment.
Should we send a 403 error for other API endpoints?
https://grafana.com/docs/tempo/latest/api_docs/#endpoints
https://grafana.com/docs/tempo/latest/api_docs/#search-tag-values-v2 could leak private data (but this will also disable the auto-complete in the tracing UI :/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag
--traces.query-rbac=trueenables query RBAC. The user will be able to see span/resource/scope attributes and events only from namespaces it can access (the list of namespaces is returned form opa-openshift).