fix(dashboard): allow scrolling in CustomSelect and project dropdown menus - #653
Open
chbndrhnns wants to merge 1 commit into
Open
fix(dashboard): allow scrolling in CustomSelect and project dropdown menus#653chbndrhnns wants to merge 1 commit into
chbndrhnns wants to merge 1 commit into
Conversation
Member
|
I really appreciate your amazing help, but please don't abuse the tests, its simple component fix no need for 3 files of tests, please cleanup the tests |
Outer portal container lacked flex layout while inner container used max-h-full, causing the child to expand to full content height without scrolling and getting clipped by parent overflow-hidden at maxHeight. Adding flex-col on the outer container and min-h-0 flex-1 on the inner container allows flexbox to properly constrain the scrollable list.
chbndrhnns
force-pushed
the
fix/dropdown-scroll
branch
from
August 21, 2026 06:17
20f18e4 to
57a2f8c
Compare
Contributor
Author
|
I kept a single regression test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #652
Problem
When connecting a Supabase database to a project via the "Use in a project" modal (
UseInProjectModal), or when usingCustomSelect/ProjectFilterwith a long list of items, the dropdown list cannot be scrolled and gets clipped.Cause
In
CustomSelect.tsx, the portal menu container hadoverflow-hiddenandmaxHeight, but was a standard block container without flex layout. The child options container usedmax-h-full(max-height: 100%), which evaluates tononeagainst an indefinite parentheight: auto. The child expanded to the full content height of all options and never overflowed its own box, while the parent'soverflow-hiddenandmaxHeightclipped the menu without enabling scrollbars.In
ProjectFilter.tsx, trailingoverflow-hiddenwas overridingoverflow-y-auto.Fix
flex flex-colto the outer container inCustomSelect.tsx.min-h-0 flex-1 overflow-y-autoso flexbox properly constrains the options container to the availablemaxHeightspace, enabling scrolling.overflow-hiddenfromProjectFilter.tsx.CustomSelect.