Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COB Transition #1853

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

COB Transition #1853

wants to merge 26 commits into from

Conversation

sebastianduesing
Copy link
Contributor

This PR transitions OBI to using COB as its upper-level ontology. Key changes include the following:

  • Replaced BFO import with COB import.
  • Replaced RO-core import with a limited import of some RO terms using OntoFox to reduce the number of BFO terms brought in by RO.
  • Redirect usages of certain non-COB terms to their COB equivalents, e.g., CHEBI:atom to COB:atom.
  • Obsolete some OBI terms that were "donated" to COB, e.g., OBI:planned process, and redirect usages of those terms to their COB equivalents.
  • Remove or substitute references to BFO terms that are no longer being imported.

@sebastianduesing sebastianduesing marked this pull request as ready for review February 27, 2025 22:22
@sebastianduesing
Copy link
Contributor Author

As of 2025-03-03, I just discovered that something is wrong with the processed material entity hierarchy in this PR. Fix coming soon.

@turbomam
Copy link
Contributor

turbomam commented Mar 3, 2025

@sebastianduesing reviewing processed material hierarchy and will update us next week (March 10th)

@sebastianduesing
Copy link
Contributor Author

False alarm—nothing's actually out of place in the processed material entity hierarchy. The differences I saw were the result of reasoning over the desired changes in the asserted hierarchy. All is as it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants