Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed description of SearchExpressions value "none" #133

Closed
wants to merge 26 commits into from
Closed

Fixed description of SearchExpressions value "none" #133

wants to merge 26 commits into from

Conversation

ralfhandl
Copy link
Contributor

HeikoTheissen
HeikoTheissen reviewed Jun 30, 2021
View reviewed changes
Copy link
Contributor

@HeikoTheissen HeikoTheissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So 0 has the same meaning as 7 (= 1 + 2 + 4)?

@ralfhandl
Copy link
Contributor Author

So 0 has the same meaning as 7 (= 1 + 2 + 4)?

UnsupportedExpressions: 0 means "you can use all expressions"

UnsupportedExpressions: 7 means "you can't use AND, OR, and NOT"

HeikoTheissen
HeikoTheissen requested changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@HeikoTheissen HeikoTheissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let others avoid the misunderstanding I suffered.

vocabularies/Org.OData.Capabilities.V1.xml Outdated Show resolved Hide resolved
@ralfhandl
More explicit descriptions
6e9b2bf 
In hind-sight the type should have been named UnsupportedSearchExpressions
@ralfhandl ralfhandl marked this pull request as draft August 9, 2021 11:22
@ralfhandl ralfhandl marked this pull request as ready for review December 14, 2021 09:37
@ralfhandl ralfhandl marked this pull request as draft March 2, 2023 07:27
@ralfhandl ralfhandl changed the base branch from main to v4.02-release-candidate June 5, 2024 16:59
@ralfhandl ralfhandl closed this Jun 6, 2024
@ralfhandl ralfhandl deleted the ODATA-1453-SearchExpressions-none branch June 6, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeikoTheissen HeikoTheissen HeikoTheissen approved these changes

Assignees
No one assigned
Labels
Capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralfhandl @HeikoTheissen