Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fields on record api and ordering within facet groups #253

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

mesemus
Copy link
Contributor

@mesemus mesemus commented Feb 25, 2024

record.record has an option "fields" to add any fields (dict field_name => field content) to record API. This can be used instead of "extra-code" to add fields on record (such as custom system fields, synthetic fields etc.)

Support for ordering within a facet group brings an option to specify the following ordering:

properties:
  propname:
    facet-groups:
      default: 3
      curator: 1

The propname will be the first facet for curator and the third one for other users

…g facet group names and values their priority (lower comes first). Facets without a priority go after the facets with explicit priority.
@mesemus mesemus requested a review from mirekys February 25, 2024 16:19
@mirekys
Copy link
Member

mirekys commented Feb 26, 2024

@mesemus we need to fix failing tests before merging

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
34.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@mirekys mirekys merged commit 3a37755 into main Feb 26, 2024
5 of 6 checks passed
@mirekys mirekys deleted the synthetic-fields-group-ordering branch February 26, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants