Fix decimal agg signature on partial companion function #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @liujiayi771 |
|
@zhouyuan We are merging this PR. Maybe it can be removed when being included in corresponding decimal agg PRs from @liujiayi771. |
zhouyuan
pushed a commit
to GlutenPerfBot/velox
that referenced
this pull request
Dec 22, 2023
Sure, will include this in the next rebase. thanks, -yuan |
zhztheplayer
pushed a commit
that referenced
this pull request
Dec 25, 2023
zhztheplayer
pushed a commit
that referenced
this pull request
Dec 27, 2023
zhztheplayer
pushed a commit
that referenced
this pull request
Dec 27, 2023
zhztheplayer
pushed a commit
that referenced
this pull request
Dec 28, 2023
zhztheplayer
added a commit
to zhztheplayer/velox
that referenced
this pull request
Dec 28, 2023
…project#465)" This reverts commit 336d61f.
zhztheplayer
pushed a commit
that referenced
this pull request
Dec 29, 2023
zhztheplayer
added a commit
to zhztheplayer/velox
that referenced
this pull request
Jan 2, 2024
…project#465)" This reverts commit 336d61f.
marin-ma
pushed a commit
that referenced
this pull request
Jan 2, 2024
zhztheplayer
added a commit
to zhztheplayer/velox
that referenced
this pull request
Jan 3, 2024
…project#465)" This reverts commit 336d61f.
zhztheplayer
added a commit
to zhztheplayer/velox
that referenced
this pull request
Jan 4, 2024
…project#465)" This reverts commit 336d61f.
zhztheplayer
added a commit
to zhztheplayer/velox
that referenced
this pull request
Jan 5, 2024
…project#465)" This reverts commit 336d61f.
zhztheplayer
added a commit
to zhztheplayer/velox
that referenced
this pull request
Jan 5, 2024
…project#465)" This reverts commit 336d61f.
zhztheplayer
added a commit
that referenced
this pull request
Jan 5, 2024
This reverts commit 336d61f.
GlutenPerfBot
pushed a commit
to GlutenPerfBot/velox
that referenced
this pull request
Jan 8, 2024
Revert "Fix decimal agg signature on partial companion function (oap-project#465)" This reverts commit 336d61f.
GlutenPerfBot
pushed a commit
to GlutenPerfBot/velox
that referenced
this pull request
Jan 9, 2024
Revert "Fix decimal agg signature on partial companion function (oap-project#465)" This reverts commit 336d61f.
GlutenPerfBot
pushed a commit
to GlutenPerfBot/velox
that referenced
this pull request
Jan 11, 2024
Revert "Fix decimal agg signature on partial companion function (oap-project#465)" This reverts commit 336d61f.
GlutenPerfBot
pushed a commit
to GlutenPerfBot/velox
that referenced
this pull request
Jan 12, 2024
Revert "Fix decimal agg signature on partial companion function (oap-project#465)" This reverts commit 336d61f.
GlutenPerfBot
pushed a commit
to GlutenPerfBot/velox
that referenced
this pull request
Jan 13, 2024
Revert "Fix decimal agg signature on partial companion function (oap-project#465)" This reverts commit 336d61f.
GlutenPerfBot
pushed a commit
to GlutenPerfBot/velox
that referenced
this pull request
Jan 14, 2024
Revert "Fix decimal agg signature on partial companion function (oap-project#465)" This reverts commit 336d61f.
GlutenPerfBot
pushed a commit
to GlutenPerfBot/velox
that referenced
this pull request
Jan 15, 2024
Revert "Fix decimal agg signature on partial companion function (oap-project#465)" This reverts commit 336d61f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We start to use partial companion functions of Final step. According to https://github.com/facebookincubator/velox/blob/main/velox/exec/AggregateInfo.cpp#L111-L112, Final step will be mapped to Single.
Refer to facebookincubator#6506 (comment) for details.