Fix type in decimal_avg and decimal_sum while spilling #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been playing around with spill in partial aggregate when we noticed velox crashes when it read data back from spill in partial aggregate. This happens when input type is of
ShortDecimal
likedecimal(12,4)
.Both these agg function produces intermediate
sum
ofLongDecimal
irrespective of input. So when input is ofLongDecimal
it works but in case ofShortDecimal
this respective dynamic type cast fails producing null pointer causing crash.