forked from facebookincubator/velox
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update StringView.h #159
Open
FelixYBW
wants to merge
114
commits into
main
Choose a base branch
from
string_view_opt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update StringView.h #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always compile Substrait (#8)
* hash join * remove extra projection
…esn't release ArrowArrayStream (#16) * ArrowStream::getOutput swallows errors * Also, call release hook after ArrowArrayStream is used
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
Fix bigint range (#40)
Remove alias (#46)
* support date type * support date type serilize
Support right semi join type in Substrait.
* Mapping the Substrait function name for Gluten and Spark SQL.
* fix int decoder * fix spark33 TPCDS q13 BigintRange not sort
1. fix rebase variantArrayToVector 2. turn off memory leak check temporarily 3. add varchar varbinary compatiable
* Fix might_contain validate fallback * add struct support
* fix aggregation mask * validate count argument size
2. remove test_filter
Support tiny int, small int and date for IN filter pushdown.
…g data (#145) * Port a patch: Refactor Thrift Transport for Parquet Metadata Access facebookincubator#4160 * Port a patch: Read Parquet Page Header with ThriftStreamingTransport to Fix the Incorrect Header Length facebookincubator#4108
* test * orc support --------- Co-authored-by: zuochunwei <[email protected]>
zhejiangxiaomai
force-pushed
the
main
branch
3 times, most recently
from
July 4, 2023 05:24
7988c5e
to
78e96ff
Compare
marin-ma
added a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data() is used very commonly but unfortunately gcc doesn't generate cmov instruction to it. While this branch can be hardly to predicate depends on the real value. Here we use asm to force to generate cmov instrucitons.