This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
[SQL-DS-CACHE-124] [POAE7-1133] Fix q44 case when enable Agg push down #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix TPC-DS q44 incorrect result when enable agg push down
e.g. select avg(col_a) group by col_b, we may have a such row
col_b_value | col_b_isNull | col_a_sum_value | col_a_isNull | ...
aaaaa | not Null | 0 | Null |
for this row, spark will do something beyond our expect,
so we make a work around set such row as null row like below
aaaaa | Null | 0 | Null |
if you have any better solution, feel free to comments or modify.
How was this patch tested?
Q44