Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Commit

Permalink
[SQL-DS-CACHE-217][POAE7-1418] add dependency exclusions to deprecate…
Browse files Browse the repository at this point in the history
…d log4j (#218)

* [POAE7-1418] add dependency exclusions to deprecated log4j

* add more exclustions related to log4j vulnerability

* update github action to follow the newest pmem-common
  • Loading branch information
iyupeng authored Dec 14, 2021
1 parent eaa6a5a commit c283f8f
Show file tree
Hide file tree
Showing 10 changed files with 80 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ape_java.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }} # todo: which pom.xml?
restore-keys: ${{ runner.os }}-m2
- name: pmem-common dependency
run: cd /tmp; git clone https://github.com/oap-project/pmem-common.git; cd pmem-common/; git checkout branch-1.1-spark-3.x; mvn install -am -q -DskipTests
run: cd /tmp; git clone https://github.com/oap-project/pmem-common.git; cd pmem-common/; mvn install -am -q -DskipTests
- name: ICL library dependency
run: cd /tmp; git clone https://github.com/Intel-bigdata/IntelCodecLibrary; cd IntelCodecLibrary/; mvn clean install
- name: Build with Maven
Expand Down
12 changes: 12 additions & 0 deletions oap-ape/ape-java/ape-benchmarks/ape-benchmark-flink-tpcds/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,18 @@
<groupId>org.pentaho</groupId>
<artifactId>pentaho-aggdesigner-algorithm</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-1.2-api</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.hive</groupId>
<artifactId>hive-llap-tez</artifactId>
</exclusion>
</exclusions>
<scope>provided</scope>
</dependency>
Expand Down
12 changes: 12 additions & 0 deletions oap-ape/ape-java/ape-benchmarks/ape-benchmark-flink-tpch/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,18 @@
<groupId>org.pentaho</groupId>
<artifactId>pentaho-aggdesigner-algorithm</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-1.2-api</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.hive</groupId>
<artifactId>hive-llap-tez</artifactId>
</exclusion>
</exclusions>
<scope>provided</scope>
</dependency>
Expand Down
10 changes: 10 additions & 0 deletions oap-ape/ape-java/ape-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,16 @@
<artifactId>hadoop-common</artifactId>
<version>${hadoop.version}</version>
<scope>provided</scope>
<exclusions>
<exclusion>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</exclusion>
<exclusion>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</exclusion>
</exclusions>
</dependency>

<!-- Test dependencies -->
Expand Down
2 changes: 1 addition & 1 deletion oap-ape/ape-java/ape-common/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<dependency>
<groupId>com.intel.oap</groupId>
<artifactId>pmem-common</artifactId>
<version>1.1.0</version>
<version>1.2.0-snapshot</version>
</dependency>
<dependency>
<groupId>org.apache.parquet</groupId>
Expand Down
4 changes: 4 additions & 0 deletions oap-ape/ape-java/ape-flink/ape-flink-1.12.0/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,10 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-1.2-api</artifactId>
</exclusion>
</exclusions>
</dependency>

Expand Down
4 changes: 4 additions & 0 deletions oap-ape/ape-java/ape-flink/ape-flink-1.13.2/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,10 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-1.2-api</artifactId>
</exclusion>
</exclusions>
</dependency>

Expand Down
24 changes: 16 additions & 8 deletions oap-ape/ape-java/ape-flink/ape-flink-common/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,14 @@
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
</exclusion>
<exclusion>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</exclusion>
<exclusion>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</exclusion>
</exclusions>
</dependency>

Expand All @@ -128,17 +136,17 @@
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
</exclusion>
<exclusion>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</exclusion>
<exclusion>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</exclusion>
</exclusions>
</dependency>

<!-- slf4j -->
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
<version>1.7.25</version>
<scope>provided</scope>
</dependency>

<!--gson-->
<dependency>
<groupId>com.google.code.gson</groupId>
Expand Down
10 changes: 10 additions & 0 deletions oap-ape/ape-java/ape-hcfs/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,16 @@
<artifactId>hadoop-common</artifactId>
<version>${hadoop.version}</version>
<scope>provided</scope>
<exclusions>
<exclusion>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</exclusion>
<exclusion>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
Expand Down
10 changes: 10 additions & 0 deletions oap-ape/ape-java/ape-spark/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,16 @@
<groupId>org.apache.spark</groupId>
<artifactId>spark-core_${scala.binary.version}</artifactId>
<version>${spark.internal.version}</version>
<exclusions>
<exclusion>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</exclusion>
<exclusion>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.apache.spark</groupId>
Expand Down

0 comments on commit c283f8f

Please sign in to comment.