Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse int96 to milliseconds #185

Conversation

jackylee-ch
Copy link

We need to keep the behavior with vanilla spark when parsing timestamp data when data is stored as int94.
The related issue: NSE-1171
The related spark suite: Migration from INT96 to TIMESTAMP_MICROS timestamp type

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@jackylee-ch jackylee-ch changed the title Parse int94 to milliseconds Parse int96 to milliseconds Dec 5, 2022
@PHILO-HE
Copy link

PHILO-HE commented Dec 5, 2022

Thanks for your patch. Could you please submit a PR for gazelle with arrow branch changed to yours? It is in order to make sure there is no possible regression issue.

@zhouyuan zhouyuan merged commit 2a65e46 into oap-project:arrow-4.0.0-oap Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants