Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packit] test in the internal TF #307

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Conversation

lachmanfrantisek
Copy link
Contributor

@lachmanfrantisek lachmanfrantisek commented Jun 25, 2021

Btw, I see you use pre-commit. Do you know https://pre-commit.ci ?

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {2: {'use_internal_tf': ['Unknown field.']}}}).

For more info, please check out the documentation: https://packit.dev/packit-as-a-service/ or contact us - Packit team

@zhukovgreen
Copy link
Contributor

@lachmanfrantisek thank you for the contribution. About pre-commit.ci do you have example project which takes advantage of their new ci system?

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {2: {'use_internal_tf': ['Unknown field.']}}}).

For more info, please check out the documentation: https://packit.dev/packit-as-a-service/ or contact us - Packit team

@lachmanfrantisek
Copy link
Contributor Author

/packit test

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {2: {'use_internal_tf': ['Unknown field.']}}}).

For more info, please check out the documentation: https://packit.dev/packit-as-a-service/ or contact us - Packit team

@lachmanfrantisek
Copy link
Contributor Author

/packit test

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {2: {'use_internal_tf': ['Unknown field.']}}}).

For more info, please check out the documentation: https://packit.dev/packit-as-a-service/ or contact us - Packit team

Signed-off-by: Frantisek Lachman <[email protected]>

The global action is used by the CLI as well,
so we can have same behaviour in CI and CLI.
@lachmanfrantisek
Copy link
Contributor Author

/packit test

@lachmanfrantisek
Copy link
Contributor Author

About pre-commit.ci do you have example project which takes advantage of their new ci system?

We use it for most of our repositories, e.g. https://github.com/packit/ogr, https://github.com/packit/packit or https://github.com/packit/packit-service

Some bigger hooks like ansible-lint do not work, but otherwise, it's really quick and updates your config weekly.

@lachmanfrantisek
Copy link
Contributor Author

@zhukovgreen The prod update is up and I've enabled your project to use internal TF. Please, take a look.

Note that TF probably does not have an image for epel-6 (@thrix, is that right?).

Can I do anything else for you here?

@zhukovgreen
Copy link
Contributor

zhukovgreen commented Jul 3, 2021

Thx @lachmanfrantisek thank you for your work. I'll adopt our tests and rebase on top of you MR so we can try it all together

Conversions of CentOS Linux 6 (epel-6 chroots) are not supported.
Running integration tests on the supported Oracle Linux 7 and 8.
@bocekm bocekm marked this pull request as ready for review August 5, 2021 10:28
@bocekm
Copy link
Member

bocekm commented Aug 5, 2021

Note that TF probably does not have an image for epel-6 (@thrix, is that right?).

I've removed running tests on CentOS Linux 6 (epel-6 copr chroot) as conversions of that system are not supported.

I've also added running the tests on the supported Oracle Linux 7 and 8.

@bocekm
Copy link
Member

bocekm commented Sep 13, 2021

Thanks, @lachmanfrantisek. I'll merge this and we'll try how it works with other PR that change the integration tests (e.g. #343 or #321)

@bocekm bocekm merged commit 21c60dc into oamg:main Sep 13, 2021
@lachmanfrantisek lachmanfrantisek deleted the internal-tf branch September 14, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants