Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci changes #424

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Ci changes #424

merged 4 commits into from
Dec 10, 2024

Conversation

dupondje
Copy link
Member

  • Drop CentOS 8
  • Use latest Alma 9
  • Upgrade CodeQL to fix deprecation
  • Fix builds due to setuptools <> packaging incompatibility

@dupondje
ci: drop centos 8
5e4ab15 
Signed-off-by: Jean-Louis Dupond <[email protected]>
@dupondje
ci: use correct alma 9 repository
a7d1be3 
Signed-off-by: Jean-Louis Dupond <[email protected]>
@dupondje
ci: upgrade codeql version
24d045b 
CodeQL v2 is deprecated and almost removed:
https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/

So upgrade to the v3 version.

Signed-off-by: Jean-Louis Dupond <[email protected]>
@dupondje
tox.ini: fix builds
3aea061 
The fix in 9897045 did not really fix the issue with setuptools and
packaging incompatibility.

The issue is that tox creates a new virtualenv with latest
setuptools/pip from pypi. But the newest setuptools version is
incompatible with the system's packaging version (20.9 on c9s).

So first thing we do is installing packaging>=22.0 into the venv to make
sure the next installs don't fail.

Signed-off-by: Jean-Louis Dupond <[email protected]>
sandrobonazzola
sandrobonazzola approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandrobonazzola sandrobonazzola merged commit ef5c9de into oVirt:master Dec 10, 2024
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandrobonazzola sandrobonazzola sandrobonazzola approved these changes

@aesteve-rh aesteve-rh Awaiting requested review from aesteve-rh aesteve-rh is a code owner

@mz-pdm mz-pdm Awaiting requested review from mz-pdm mz-pdm is a code owner

@almusil almusil Awaiting requested review from almusil almusil is a code owner

@tinez tinez Awaiting requested review from tinez tinez is a code owner

Assignees

@dupondje dupondje

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dupondje @sandrobonazzola