Extend ovirt_nic with mac address manage #487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Vatson112 The blocking PR has been merged. The new feature for managing and reading MACs is available in v2.1.0 |
|
@Vatson112 are you still interested in merging this PR? If yes, please add a signoff and rebase your PR, there's a release upcoming in a couple of days. |
Signed-off-by: mn.albeschenko <[email protected]>
Vatson112
force-pushed
the
extend-nic-with-mac
branch
from
54b4be1
to
6f75609
Compare
|
@janosdebugs |
ghost
suggested changes
Jan 31, 2023
There was a problem hiding this comment.
The change looks good, but there are no tests for the MAC address. Please add a test to internal/ovirt/resource_ovirt_nic_test.go that tests setting and reading back the MAC address.
Edit: also, please run go generate to generate the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the change you are making
Allow manage and read MAC address of VM NIC interfaces.
Issue reference: #484
Wait till PR in OvirtClient merged.
...
Are you the owner of the code you are sending in, or do you have permission of the owner?
Yes
...
The code will be published under the BSD 3 clause license. Have you read and understood this license?
Yes
...