Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add Events view" #1604

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Revert "Add Events view" #1604

merged 3 commits into from
Jun 16, 2022

Conversation

sgratch
Copy link
Member

@sgratch sgratch commented Jun 16, 2022

Reverts #1592

Due to few functional aspects of this solution, specifically concerning permissions and info that the user shouldn't been exposed to. Let's re-think about a better solution for this for next release. Since it's a new functionality, there is no problem with reverting for now

@ovirt-infra
Copy link

All tests passed

@ovirt-infra
Copy link

All tests passed

@sgratch sgratch requested review from sjd78 and rszwajko June 16, 2022 20:27
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

VM event view is gona and I see no UI or console errors.

@sgratch
Copy link
Member Author

sgratch commented Jun 16, 2022

/ost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants