Display notification after successful snapshot restore

oVirt · Jun 9, 2022 · 43c835f · 43c835f
1 parent 6e2ba4d
commit 43c835f
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/src/components/VmDetails/cards/SnapshotsCard/actions.js b/src/components/VmDetails/cards/SnapshotsCard/actions.js
@@ -20,12 +20,14 @@ export function addVmSnapshot ({ vmId, snapshot }) {
   }
 }
 
-export function restoreVmSnapshot ({ vmId, snapshotId }) {
+export function restoreVmSnapshot ({ vmId, vmName, snapshotId, snapshotName }) {
   return {
     type: RESTORE_VM_SNAPSHOT,
     payload: {
       vmId,
       snapshotId,
+      vmName,
+      snapshotName,
     },
   }
 }
diff --git a/src/components/VmDetails/cards/SnapshotsCard/sagas.js b/src/components/VmDetails/cards/SnapshotsCard/sagas.js
@@ -1,4 +1,4 @@
-import { takeEvery, put } from 'redux-saga/effects'
+import { takeEvery, put, select } from 'redux-saga/effects'
 
 import Api, { Transforms } from '_/ovirtapi'
 import { callExternalAction, delay, delayInMsSteps } from '_/sagas/utils'
@@ -13,9 +13,11 @@ import {
   updateVmSnapshot,
   startActionInProgress,
   stopActionInProgress,
+  addUserMessage,
 } from '_/actions'
 
 import { ADD_VM_SNAPSHOT, DELETE_VM_SNAPSHOT, RESTORE_VM_SNAPSHOT } from './constants'
+import { toJS } from '_/helpers'
 
 function* addVmSnapshot (action) {
   const { vmId } = action.payload
@@ -68,13 +70,21 @@ function* deleteVmSnapshot (action) {
 
 function* restoreVmSnapshot (action) {
   const { vmId, snapshotId } = action.payload
+  const [{ description: snapshotName } = {}, vmName] = yield select(({ vms }) => [
+    toJS(vms.getIn(['vms', vmId, 'snapshots'], [])).find(({ id }) => id === snapshotId),
+    vms.getIn(['vms', vmId, 'name']),
+  ])
   yield put(addSnapshotRestorePendingTask(vmId, snapshotId))
   yield put(startActionInProgress({ vmId, name: 'restoreSnapshot' }))
 
   const result = yield callExternalAction(Api.restoreSnapshot, action)
 
   yield put(stopActionInProgress({ vmId, name: 'restoreSnapshot', result }))
   yield put(removeSnapshotRestorePendingTask(vmId, snapshotId))
+  if (!result.error) {
+    // restore is synchronous operation so we can interpret completed operation as success
+    yield put(addUserMessage({ messageDescriptor: { id: 'restoredSnapshot', params: { snapshotName, vmName } }, type: 'SUCCESS' }))
+  }
 }
 
 export default [

diff --git a/src/intl/messages.js b/src/intl/messages.js
@@ -609,6 +609,7 @@ export const messages: { [messageId: string]: MessageType } = {
     description: 'Confirmation modal action button label for a Restore operation',
   },
   restoreSnapshot: 'Restore Snapshot?',
+  restoredSnapshot: 'Finished restoring snapshot {snapshotName} of VM {vmName}',
   results: {
     message: '{total} Results',
     description: 'Number of filtered fetched VMs (including pools)',