Skip to content

Conversation

@cambel
Copy link
Contributor

@cambel cambel commented Dec 3, 2021

Update dependencies on the Dockerfile and the submodules to remove compilation errors.

Also, use MoveIt from the source only to remove the error with the moveit_msgs change.

@felixvd
Copy link
Contributor

felixvd commented Dec 7, 2021

Sorry for the late review. Could you explain what you mean by "the error with the moveit_msgs change"? I do not have a machine to build this on, so I cannot confirm myself.

If I remember correctly, MoveIt does not build without moveit-resources, so they will be downloaded as a dependency either way, and including them in the Docker image avoids redownloading them every time the container is regenerated. Am I misremembering? Has something about this changed? Or are all the dependencies already in the .rosinstall file, so the install is redundant?

Apart from that it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants