(proof-systems) Native Prover with Napi - GateVector
#3341
Conversation
querolita
force-pushed
the
native/napi-polycomm
branch
from
d1e0e48 to
e913408
Compare
querolita
force-pushed
the
native/napi-gatevector
branch
2 times, most recently
from
a726918 to
d002456
Compare
querolita
changed the title
proof-systems) Native Prover with Napi - Gate Vectorproof-systems) Native Prover with Napi - Gate Vector
querolita
force-pushed
the
native/napi-gatevector
branch
from
cc6304b to
18e19f6
Compare
querolita
changed the title
proof-systems) Native Prover with Napi - Gate Vectorproof-systems) Native Prover with Napi - GateVector
querolita
force-pushed
the
native/napi-polycomm
branch
from
31af9cf to
0d95c15
Compare
querolita
force-pushed
the
native/napi-gatevector
branch
from
18e19f6 to
fd41b37
Compare
(`proof-systems`) Native Prover with Napi - SRS
(Native prover) prover index
|
I am afraid I merged So, in order to make review of this one PR, I pushed a branch called Also, the following commits are also part of the GateVector alone (annotations with js_name) |
| } | ||
| } | ||
|
|
||
| #[napi(js_name = [<"caml_pasta_" $field_name:snake "_plonk_gate_vector_create">])] |
There was a problem hiding this comment.
ah so this does work with the templates? nice!
| caml_pasta_fq_plonk_gate_vector_digest, caml_pasta_fq_plonk_gate_vector_from_bytes, | ||
| caml_pasta_fq_plonk_gate_vector_get, caml_pasta_fq_plonk_gate_vector_len, | ||
| caml_pasta_fq_plonk_gate_vector_to_bytes, caml_pasta_fq_plonk_gate_vector_wrap, | ||
| NapiFpGate as WasmFpGate, NapiFpGateVector as WasmFpGateVector, NapiFqGate as WasmFqGate, |
There was a problem hiding this comment.
this was actually a little confusing when i worked on top of this PR - I think we should probbably leave it as NapiXX and leave it to the crate that imports these to rename them if needed, wdyt? we cna do this in a follow up PR tho
| } | ||
|
|
||
| // TOOD: remove incl all dependencies when no longer needed and we only pass napi objects around | ||
| #[napi(js_name = "prover_index_fp_from_bytes")] |
Trivo25
left a comment
Trivo25
left a comment
There was a problem hiding this comment.
Looks good to me! Some minor things but we can clean them up in a final review
Implements wrappers and functions to enable gate-vector-related FFIs.
o1js side:
o1-labs/o1js@6fbc6a3o1-labs/o1js#2564mina side: MinaProtocol/mina#17951
proof-systems side: #3341 (this)
(Parent PR: #3340)
Closes o1-labs/o1js#2476 o1-labs/o1js#2480 o1-labs/o1js#2479 o1-labs/o1js#2482 o1-labs/o1js#2484