rm js-sha256 #2539
Open
rm js-sha256 #2539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45930
force-pushed
the
2025-10-rm-js-sha256
branch
from
b82f48e to
7c866d1
Compare
bleepbloopsify
approved these changes
Oct 10, 2025
commit: |
Trivo25
reviewed
Oct 13, 2025
| } | ||
|
|
||
| function computeChecksum(input: number[] | Uint8Array) { | ||
| let inputBytes = input instanceof Uint8Array ? input : new Uint8Array(input); |
There was a problem hiding this comment.
nit: let inputBytes = new Uint8Array(input); should be enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js-sha256 edits the prototype, and Lumina noticed that sporadically, they got an error where this behavior is the primary suspect: https://github.com/emn178/js-sha256/blob/bacba8e8c6d6a79a6505ba52edbad55ec5509b19/src/sha256.js#L394
Modifying the prototype can be blocked in certain runtimes and bundlers that freeze objects by default, but since it doesn't happen every time, it's hard to pinpoint the exact issue.
I'd like to package this PR as a branch release and provide it to the Lumina team to test with.