-
Notifications
You must be signed in to change notification settings - Fork 41
Replayer node - add documentation #1620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
OCaml Reference Validation ResultsRepository: https://github.com/MinaProtocol/mina.git Click to see full validation output |
f73f249 to
8fe7e93
Compare
3853157 to
689be1d
Compare
0xMimir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment for optional improvement, other than that LGTM
| /// mina replay state-with-input-actions ~/.mina/recorder | ||
| /// ``` | ||
| #[arg(long, default_value = "none", env)] | ||
| pub record: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are already adding docs, it would be better if record parsing was handled by clap so that if invalid value is passed, node doesn't panic
✓ Code Reference Verification PassedAll code references in the documentation have been verified successfully! Total references checked: 1 The documentation is in sync with the codebase on the |
8fa02c7 to
c92b28b
Compare
c92b28b to
106380e
Compare
No description provided.