-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scout format ! #74
Scout format ! #74
Conversation
5f8478d
to
592e3a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=========================================
+ Coverage 85.34% 92.54% +7.2%
=========================================
Files 5 7 +2
Lines 546 604 +58
=========================================
+ Hits 466 559 +93
+ Misses 80 45 -35
Continue to review full report at Codecov.
|
41a8b0d
to
2f6e2a0
Compare
I'm going to work on tests, and submit it. |
2f6e2a0
to
810c707
Compare
9b158c8
to
ba2f123
Compare
ba2f123
to
0c154e4
Compare
5a9ed15
to
354d0e1
Compare
Yay CI passes after 3 minutes instead of 15 |
51fbf92
to
6008e32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @o0Ignition0o, this is a great step forward for cargo-scout!
I think there's only a minor problem with the CI, the rest of comments I left are nits :)
Awesome job!
Also, not related to this PR though, some thoughts on usability. I was testing the changes on an old copy of the repo, and the master branch was really old. I forgot that the default target branch is master (I was on this branch), so I was not getting the expected results. Do you think that it would make sense to use |
That's a very good idea indeed, let's file an issue for it, it probably would make more sense than master as a default setting ! |
6008e32
to
f836efe
Compare
Added a build cache + Avoid running tests twice on stable.
f836efe
to
2226b1a
Compare
Thank you so much for such a thorough review, that allowed us to catch the bug ! |
Will fix #72 sooner than expected :D
todo: handle relative/absolute paths in the rustfmt linter, and later provide a --fix option