[Chore #159033109] Write end-to-end test

1. Update readme with instructions for end to end testing 2. install and setup nightwatch module, selenium and jdk for end to end testing 3. Modify script to run end2end test in package.json 4. Write end2end test for center 5. Write end2end tests for users 6. Write end to end tests for events 7. Implement feedback on component test: better description [Finishes #159033109]
nzediegwu1 · Jul 17, 2018 · ddd5204 · ddd5204
1 parent 8f0b229
commit ddd5204
Show file tree

Hide file tree

Showing 42 changed files with 3,947 additions and 182 deletions.
diff --git a/.codeclimate.yml b/.codeclimate.yml
@@ -15,4 +15,6 @@ checks:
 exclude_paths:
 - "server/migrations"
 - "server/tests"
-- "client/__test__"
+- "client/__test__"
+- "e2e_files"
+- "end2end"
diff --git a/.gitignore b/.gitignore
@@ -17,3 +17,4 @@ npm-debug.log.3159501567
 .DS_Store
 template/.DS_Store
 dist
+/reports
diff --git a/README.md b/README.md
@@ -98,9 +98,9 @@ Given you manage an events center, this app will help you accept applications to
 
 
 ## Testing the Application
-    1. "npm test" →  run API tests
-    2. "npm run test:e2e" → Runs end-to-end unit tests
-    3. "npm run test:react" → Runs frontend tests
+    1. API test → "npm run test:api"
+    2. End-to-end test → Install latest JDK, Set superAdmin username and password using `SUPER_ADMIN` and `SUPER_ADMIN_PASS` respectively in your .env file, then run "npm run test:e2e" 
+    3. Frontend test → "npm run test:react"
 
 ## Documentation
 

diff --git a/client/__test__/components/__snapshots__/centerDetails.test.js.snap b/client/__test__/components/__snapshots__/centerDetails.test.js.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Tests for addEvent component should render self without crashing 1`] = `
+exports[`Tests for centerDetails component should render self without crashing 1`] = `
 <div>
   <h2>
     Loading...

diff --git a/client/__test__/components/__snapshots__/centerList.test.js.snap b/client/__test__/components/__snapshots__/centerList.test.js.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Tests for addEvent component should render self without crashing 1`] = `
+exports[`Tests for centerList component should render self without crashing 1`] = `
 <div
   className="mx-sm-auto col-sm-11"
 >
@@ -11,6 +11,7 @@ exports[`Tests for addEvent component should render self without crashing 1`] =
   </b>
   <Filter
     handleSearch={[Function]}
+    id="filter-centers"
     placeholder="Filter by name or location..."
   />
   <div

diff --git a/client/__test__/components/__snapshots__/centerRouter.test.js.snap b/client/__test__/components/__snapshots__/centerRouter.test.js.snap
diff --git a/client/__test__/components/__snapshots__/sidebar.test.js.snap b/client/__test__/components/__snapshots__/sidebar.test.js.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Tests for addEvent component should render self without crashing 1`] = `
+exports[`Tests for sidebar component should render self without crashing 1`] = `
 <div
   aria-hidden="true"
   aria-labelledby="myModalSidebarLabel"
@@ -29,6 +29,7 @@ exports[`Tests for addEvent component should render self without crashing 1`] =
         </h5>
         <div
           data-dismiss="modal"
+          id="toggle-sidebar"
         >
           <Icon
             alt="close"
@@ -52,21 +53,21 @@ exports[`Tests for addEvent component should render self without crashing 1`] =
           />
           <ListItem
             alt="myCenters"
-            class="nav-item"
+            class="nav-item center-list"
             event={[Function]}
             icon="glyphicons-503-map.png"
             title="Centers"
           />
           <ListItem
             alt="myProfile"
-            class="nav-item"
+            class="nav-item user-profile"
             event={[Function]}
             icon="glyphicons-4-user.png"
             title="MyProfile"
           />
           <ListItem
             alt="userList"
-            class="nav-item allUsers"
+            class="nav-item all-users"
             event={[Function]}
             icon="glyphicons-44-group.png"
             title="All Users"

diff --git a/client/__test__/components/__snapshots__/signin.test.js.snap b/client/__test__/components/__snapshots__/signin.test.js.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Tests for addEvent component should render self without crashing 1`] = `
+exports[`Tests for signin component should render self without crashing 1`] = `
 <Redirect
   push={false}
   to="/dashboard"

diff --git a/client/__test__/components/__snapshots__/signup.test.js.snap b/client/__test__/components/__snapshots__/signup.test.js.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Tests for addEvent component should render self without crashing 1`] = `
+exports[`Tests for signup component should render self without crashing 1`] = `
 <form
   className="formDiv"
   id="signupForm"

diff --git a/client/__test__/components/centerDetails.test.js b/client/__test__/components/centerDetails.test.js
@@ -10,7 +10,7 @@ import {
 
 configure({ adapter: new Adapter() });
 
-describe('Tests for addEvent component', () => {
+describe('Tests for centerDetails component', () => {
   const props = {
     match: {
       params: {
@@ -28,12 +28,7 @@ describe('Tests for addEvent component', () => {
     const wrapper = shallow(<CenterDetailsComponent {...props} />);
     expect(wrapper).toMatchSnapshot();
   });
-  it('should render call setPage function when comopnent unmounts', () => {
-    const wrapper = shallow(<CenterDetailsComponent {...props} />);
-    wrapper.unmount();
-    expect(props.setPage).toHaveBeenCalled();
-  });
-  it('should render call setPage function when comopnent unmounts', () => {
+  it('should call setPage function when comopnent unmounts', () => {
     const wrapper = shallow(<CenterDetailsComponent {...props} />);
     wrapper.unmount();
     expect(props.setPage).toHaveBeenCalled();

diff --git a/client/__test__/components/centerList.test.js b/client/__test__/components/centerList.test.js
@@ -6,7 +6,7 @@ import { CenterList } from '../../src/components/centerListComponent';
 
 configure({ adapter: new Adapter() });
 
-describe('Tests for addEvent component', () => {
+describe('Tests for centerList component', () => {
   const props = {
     centers: [],
     match: {},

diff --git a/client/__test__/components/centerRouter.test.js b/client/__test__/components/centerRouter.test.js
diff --git a/client/__test__/components/manageDetailsHeader.test.js b/client/__test__/components/manageDetailsHeader.test.js
@@ -30,7 +30,7 @@ function setup() {
   };
 }
 
-describe('Tests for addEvent component', () => {
+describe('Tests for manageDetailsHeader component', () => {
   it('should render self without crashing', () => {
     const { enzymeWrapper } = setup();
     expect(enzymeWrapper.length).toBe(1);

diff --git a/client/__test__/components/manageEvent.test.js b/client/__test__/components/manageEvent.test.js
@@ -25,7 +25,7 @@ function setup() {
   };
 }
 
-describe('Tests for addEvent component', () => {
+describe('Tests for manageEvent component', () => {
   it('should render self without crashing', () => {
     const { enzymeWrapper, props } = setup();
     expect(enzymeWrapper.length).toBe(1);

diff --git a/client/__test__/components/sidebar.test.js b/client/__test__/components/sidebar.test.js
@@ -10,7 +10,7 @@ import {
 
 configure({ adapter: new Adapter() });
 
-describe('Tests for addEvent component', () => {
+describe('Tests for sidebar component', () => {
   const props = {
     match: {},
     setProfileDetails: jest.fn(),

diff --git a/client/__test__/components/signin.test.js b/client/__test__/components/signin.test.js
@@ -10,7 +10,7 @@ import {
 
 configure({ adapter: new Adapter() });
 
-describe('Tests for addEvent component', () => {
+describe('Tests for signin component', () => {
   const props = {
     history: {},
     setSubmitState: jest.fn(),

diff --git a/client/__test__/components/signup.test.js b/client/__test__/components/signup.test.js
@@ -6,7 +6,7 @@ import { SignupComponent, mapDispatchToProps } from '../../src/components/signup
 
 configure({ adapter: new Adapter() });
 
-describe('Tests for addEvent component', () => {
+describe('Tests for signup component', () => {
   const props = {
     changeState: jest.fn(),
     changeSubmitState: jest.fn(),

diff --git a/client/src/components/addCenterComponent.js b/client/src/components/addCenterComponent.js
@@ -20,12 +20,11 @@ const inputAttrs = (inputType, inputName, placeholder, className, ref, required,
   required,
   autocomplete,
 });
-
-const mapDispatchToProps = dispatch => ({
-  setCenterDetails: center => dispatch(setCenterDetails(center)),
-  setSubmitState: submitState => dispatch(setSubmitState(submitState)),
-  setCenterDefaults: submitState => dispatch(setCenterDefaults(submitState)),
-});
+const actionCreators = {
+  setCenterDetails,
+  setSubmitState,
+  setCenterDefaults,
+};
 
 const mapStateToProps = state => ({
   modalTitle: state.page.modalTitle,
@@ -121,7 +120,7 @@ export class AddCenterComponent extends React.Component {
                     'text',
                     'centername',
                     'Center Name',
-                    'form-control input-sm',
+                    'form-control input-sm center-name',
                     input => (this.name = input),
                     'required'
                   )}
@@ -133,7 +132,7 @@ export class AddCenterComponent extends React.Component {
                     'file',
                     'centerImage',
                     'Center Image',
-                    'form-control input-sm',
+                    'form-control input-sm center-image',
                     input => (this.picture = input),
                     required
                   )}
@@ -145,7 +144,7 @@ export class AddCenterComponent extends React.Component {
                     'text',
                     'street',
                     'Address',
-                    'form-control input-sm',
+                    'form-control input-sm center-address',
                     input => (this.address = input),
                     'required',
                     'street-address'
@@ -158,7 +157,7 @@ export class AddCenterComponent extends React.Component {
                     'text',
                     'city',
                     'State/City',
-                    'form-control input-sm',
+                    'form-control input-sm center-city',
                     input => (this.location = input),
                     'required',
                     'address-level2'
@@ -171,7 +170,7 @@ export class AddCenterComponent extends React.Component {
                     'number',
                     'capacity',
                     'Capacity',
-                    'form-control input-sm',
+                    'form-control input-sm center-capacity',
                     input => (this.capacity = input),
                     'required'
                   )}
@@ -183,7 +182,7 @@ export class AddCenterComponent extends React.Component {
                     'number',
                     'bookingAmount',
                     'Booking price(per day)',
-                    'form-control input-sm',
+                    'form-control input-sm center-price',
                     input => (this.price = input),
                     'required'
                   )}
@@ -192,14 +191,16 @@ export class AddCenterComponent extends React.Component {
                   <select
                     required
                     ref={input => (this.availability = input)}
-                    className="custom-select-sm"
+                    className="custom-select-sm center-availability"
+                    id="set-availability"
                   >
                     <Option value="" text="Availability" disabled selected />
                     <Option value="open" text="open" />
                     <Option value="close" text="close" />
                   </select>
                 </div>
                 <ModalFooter
+                  id="add-center-button"
                   type="submit"
                   disabled={this.props.disabled}
                   display={this.props.visibility}
@@ -213,7 +214,7 @@ export class AddCenterComponent extends React.Component {
     );
   }
 }
-export const AddCenter = connect(mapStateToProps, mapDispatchToProps)(AddCenterComponent);
+export const AddCenter = connect(mapStateToProps, actionCreators)(AddCenterComponent);
 AddCenterComponent.propTypes = {
   modalTitle: PropTypes.string,
   required: PropTypes.oneOfType([PropTypes.bool, PropTypes.string]),