Skip to content

Conversation

@PDA-1
Copy link

@PDA-1 PDA-1 commented Sep 20, 2025

Bug:
When the string "AV1" is in the filename, guessit recognizes it as the title of the show.

Fix:

  • Added support for "AV1", in the guessit config file.
  • Added test case for future verification.

PDA-1 and others added 6 commits July 26, 2025 06:56
added workaround for titles with 2 numbers with a dash betwwen them (which guessit has problems with)
workaround for titles with 2 numbers with a dash between them (which guessit has problems with)
added workaround for titles with 2 numbers with a dash between them (which guessit has problems with)
@dnzbk dnzbk self-requested a review September 21, 2025 13:41
@dnzbk
Copy link
Collaborator

dnzbk commented Sep 21, 2025

Looks good to me, but could you add another guessit library patch (Patch 2) description to the README just like you did here?

@PDA-1
Copy link
Author

PDA-1 commented Sep 23, 2025

Should I add it to the same patch?
After all they are very minor patches, and there is no need for a "special" patch for each one..

@dnzbk
Copy link
Collaborator

dnzbk commented Sep 23, 2025

Should I add it to the same patch? After all they are very minor patches, and there is no need for a "special" patch for each one..

Even if the patches are small, they are still patches. Besides, if the guessit library is abandoned, the patches will likely become bigger over time.
So just please add the following to the README:
[Patch 2](https://github.com/nzbgetcom/Extension-VideoSort/pull/19) added support for A1 format by [PDA-1](https://github.com/PDA-1)

Could you please update the link for Patch 1? It currently points to the guessit repository and should be changed to your PR: https://github.com/nzbgetcom/Extension-VideoSort/pull/14.
Thanks.

@PDA-1
Copy link
Author

PDA-1 commented Sep 23, 2025

Done.

I misunderstood you original request, I thought you wanted me to create a new patch branch of guessit, and commit the change there.

@dnzbk dnzbk merged commit 4f9076f into nzbgetcom:master Sep 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants