FIX: Videosort crushes with series name with 2 numbers and a dash #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added workaround for titles with 2 numbers with a dash betwwen them (which guessit has problems with)
workaround for titles with 2 numbers with a dash between them (which guessit has problems with)
dnzbk
reviewed
Jul 28, 2025
added workaround for titles with 2 numbers with a dash between them (which guessit has problems with)
Author
|
Done. |
dnzbk
approved these changes
Jul 28, 2025
Collaborator
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Videosort crushes with series name with 2 numbers and a dash.
This is caused due to a list is returned from guessit (and not string) when such a case occur.
When a list is retuned then a string is expected, Videosort crushes with a TypeError error.
Since no one is maintaining guessit on github anymore, there is no point waiting for a fix from them,
I have created a workaround (similar to other guessit workarounds), that joins all the parts of the list into one string.
I have also added a test case to test it in future times.