Skip to content

Conversation

@PDA-1
Copy link

@PDA-1 PDA-1 commented Apr 30, 2025

Sometimes, an episode is identified as series, even when it has a date in the filename. This causes wrong filename to be created.

In case of a movie, there is a check if it contains a date, and if so it's marked as dated. This check doesn't exists in case of an episode, so this fix adds it.

Sometimes, an episode is identified  as series, even when it has a date in the filename. 
This causes wrong filename to be created.

In case of a movie, there is a check if it contains a date, and if so it's marked as dated.
This check doesn't exists in case of an episode, so this fix adds it.
@dnzbk dnzbk self-requested a review April 30, 2025 18:47
@dnzbk
Copy link
Collaborator

dnzbk commented May 1, 2025

Thanks for the fix. To ensure proper coverage, could you add such test cases to the testdata.json file?

@PDA-1
Copy link
Author

PDA-1 commented May 1, 2025

Happy to help, I've been using Video Sort for years now, and it's nice to be able to give something back.
It's actually my first ever code change on github.

About an example, it's tricky, it happens to me with some specific episodes which looks normal (always with "The Daily Show"), only few time every few weeks. I couldn't find the pattern for the issue.
It's probably something inside the guessit module.
When I went over the code, and saw the missing condition, I added the condition, re-run a failed file, and it worked.

@dnzbk
Copy link
Collaborator

dnzbk commented May 1, 2025

Ok, I see.
I tested it and everything looks good.
The changes are straightforward and should not break anything.

@dnzbk dnzbk merged commit fd85c83 into nzbgetcom:master May 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants