Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: encoding, path to NZBfile on Windows, code formatting, round the max failed limit #5

Merged
merged 10 commits into from
May 8, 2024
Merged

Fix: encoding, path to NZBfile on Windows, code formatting, round the max failed limit #5

merged 10 commits into from
May 8, 2024

Conversation

dnzbk
Copy link
Collaborator

@dnzbk dnzbk commented May 2, 2024 •
edited
Loading

Description

#143

  • fixed a UnicodeEncodeError exception that occurs when using special characters in names;
  • fixed several "NoneType" errors;
  • fixed wrong path to NZB file on Windows;
  • rounded the failed limit precision value;
  • added tests and pipeline for tests;
  • formatted the code using Black.

Testing

  • Windows 11/NZBGet v24.1;
  • macOS Ventura/NZBGet v24.1.

@dnzbk dnzbk requested review from phnzb and luckedea May 3, 2024 06:49
@dnzbk dnzbk changed the title Fix: encoding, path to NZBfile on Windows, code formatting Fix: encoding, path to NZBfile on Windows, code formatting, max failed limit precision May 7, 2024
@dnzbk dnzbk changed the title Fix: encoding, path to NZBfile on Windows, code formatting, max failed limit precision Fix: encoding, path to NZBfile on Windows, code formatting, round the max failed limit May 7, 2024
@dnzbk dnzbk merged commit 2848894 into main May 8, 2024
1 check passed
@dnzbk dnzbk deleted the fix/encoding branch May 8, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luckedea luckedea luckedea approved these changes

@phnzb phnzb Awaiting requested review from phnzb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnzbk @luckedea