Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user apps #641

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Add user apps #641

merged 5 commits into from
Mar 20, 2024

Conversation

MCausc78
Copy link
Contributor

Description

  • Add integrationTypes/context to Interaction
  • Add integrationTypesConfig to Application
  • Add integrationTypes/contexts to ApplicationCommandBuilder/ApplicationCommandUpdateBuilder
  • Deprecate MessageInteraction, and message.interaction
  • Interaction.appPermissions is no longer null
  • Add tests

PRs:

Breaking changes are made by Discord

Connected issues & other potential problems

Probably nyxx_commands

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@l7ssha l7ssha added the enhancement New feature or request label Mar 18, 2024
@l7ssha l7ssha added this to the 6.2.0 milestone Mar 18, 2024
abitofevrything
abitofevrything requested changes Mar 18, 2024
View reviewed changes
lib/src/builders/application.dart Outdated Show resolved Hide resolved
lib/src/http/managers/application_command_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/application_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/interaction_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/message_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/message_manager.dart Outdated Show resolved Hide resolved
@abitofevrything abitofevrything merged commit 10181ac into nyxx-discord:dev Mar 20, 2024
3 checks passed
@MCausc78 MCausc78 deleted the user-apps branch March 20, 2024 19:35
abitofevrything pushed a commit that referenced this pull request Apr 1, 2024
@MCausc78 @abitofevrything
Add user apps (#641)
55bdbec 
* add user apps

* few fixes, and make `appPermissions` not-null

* make `oauth2InstallParameters` nullable, as discord not giving that field if install link is none

* make `contexts` empty by default

* Apply abito changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abitofevrything abitofevrything abitofevrything approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
nyxx roadmap
Status: Done
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MCausc78 @abitofevrything @l7ssha