Fuzzer for bmv2 #39
Draft
Fuzzer for bmv2 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
requested changes
Feb 2, 2025
| endif() | ||
|
|
||
| # Find p4c (for JSON generation) | ||
| find_program(P4C_EXECUTABLE p4c) |
There was a problem hiding this comment.
This is the wrong way to do this, this is why the current tests fail. You directly access the P4C binary in the script, you shouldn't need to use find_program.
| @@ -4,6 +4,17 @@ if(ENABLE_TESTING) | |||
| include(test/P4Tests.cmake) | |||
| endif() | |||
|
|
|||
| find_program(RTSMITH_DRIVER p4rtsmith) | |||
There was a problem hiding this comment.
We already set this binary with a variable, you just need to use that variable. Do not use find_program
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.