Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add js variable to check if AAC is successful or not #7755

Open
wants to merge 2 commits into
base: nw55
Choose a base branch
from

Conversation

swethanagopisetti
Copy link

Original AAC PR: #7698

While testing AAC feature, I realized that it would be nice to have a variable whose value reflects the successful start of AAC instead of having to look into the logs. The purpose of this PR is to add such a variable.

More details about this pull request:

  1. It adds a javascript variable called "isAACActive" which checks the value of session.active. The value of session.active is set by the successful start of AAC.
    Example:
    let x = nw.Window.get(window); x.enterKioskMode();
    ...
    console.log(x.isAACActive); // It should return True if AAC starts and False otherwise.
  2. The value of the variable "x.isAACActive" is set to False by default on non-OSX platforms.

Note: I have a hard time building it to fully test it but I hope that the code is okay and may be it can be tested from the build system's nightly build.

@bluthen
Copy link
Contributor

bluthen commented Aug 9, 2022

What work needs to be done for this to be merged. Someone need to do a test build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants