Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #2817

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update README.md #2817

wants to merge 1 commit into from
+30 −8

Conversation

ArdentDev
Copy link

No description provided.

ljharb
ljharb requested changes May 22, 2022
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very confused what this is attempting to do.

README.md
### Install NVM on macOS
Change the ownership of these directories to your user
```sh
sudo chown -R $(whoami) /usr/local/share/zsh /usr/local/share/zsh/site-functions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most nvm users don't use zsh.

README.md
```

Use Humebrew to install NVM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nobody should EVER use homebrew to install nvm; homebrew-installed nvm is 100% unsupported and discouraged.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me using macbook pro m1 it's the only way nvm work :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn’t be the case; node itself only supports m1 outside of Rosetta on v16+, but nvm itself should work fine.

@ljharb ljharb marked this pull request as draft December 23, 2022 19:36
@ljharb ljharb force-pushed the master branch 2 times, most recently from c6cfc3a to c20db2a Compare June 10, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzienisz dzienisz dzienisz left review comments

@ljharb ljharb ljharb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArdentDev @ljharb @dzienisz