Skip to content
This repository has been archived by the owner on Nov 26, 2023. It is now read-only.

move js to ecma to avoid jsx problems #4

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

elgiano
Copy link
Contributor

@elgiano elgiano commented Oct 27, 2022

Issue #3 is probably due to nvim-treesitter/nvim-treesitter@69a55e8

Note also this previous commit nvim-treesitter/nvim-treesitter@3b8c2ea message:

create ecma base for use in js and ts which fixes jsx issues

Typescript injections should not import javascript, which pulls jsx, but ecma.
So I moved javascript injections to ecma, and I removed the typescript injections all together, since they already inherit from ecma.

@kohane27
Copy link

Thank you so much! Can confirm that your solution works perfectly.
Was blind without syntax highlighting from the inline templates and styles but now no more!
Much appreciated!

@kjbetz
Copy link

kjbetz commented Jan 5, 2023

Hi, @elgiano and @kohane27!

Thanks for fixing this!

Is there anything I need to do to get it working properly? I installed this branch... my inline templates are still not being highlighted. Any gotcha's I need to have set up with nvim-treesitter?

Thanks!

@kohane27
Copy link

kohane27 commented Jan 6, 2023

@kjbetz If you were using packer:

use({ "elgiano/nvim-treesitter-angular", branch = "topic/jsx-fix" })

the run :TSUpdate to see if it works.

@kjbetz
Copy link

kjbetz commented Jan 11, 2023

@kohane27, thanks for the reply!

I just figured out I had an issue with the html parser being compiled and installed correctly. I fixed that and now I have inline template highlighting working.

Thanks to you both!

@osenvosem
Copy link

@steelsojka could you merge this please?

@zapling
Copy link

zapling commented Jul 25, 2023

Can confirm that this fix still works as expected

@jigfox
Copy link

jigfox commented Aug 4, 2023

what needs to be done, to get this merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants