feat: Add icon for tailwind config #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronitkrshah
changed the title
|
The distinction in tsx/jsx colours was added by @ptakpatryk in #214 I reckon that distinction is useful. Why remove it? Tailwind addition looks good. |
|
Yes please leave different colours for .tsx and .jsx - it's particularly useful when porting from JS to TS and you have both types in one repo. |
|
You make a valid point. Having both .tsx and .jsx files in the repository, this color will assist us in differentiating between tsx and jsx files. Alright, I'm reverting the tsx commit. |
This reverts commit c7af526.
ronitkrshah
changed the title
alex-courtis
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First Commit
Previous
tsxcolor was good but that color is a little bit darker. That's why using the same color asjsxfortsxPrevious
Updated
Second Commit
Add icon for filename
tailwind.config.jsfrom official nerd fonts iconf13ff