feat: Allow to expand until certain condition is met #2790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to solve #2789
With this change I can now define the following mapping:
This works as expected however it has some downsides:
expand_all
function will not expand the last directory. It stops as soon asshould_expand
returnsfalse
but I wanted the last directory to be expanded.I had to copyreplaced withpopulate_children
method which is not a part of public apiexplorer.explore(node, status)
Btw if this got accepted in some form I am going to replace the default expand behavior in my config with this, since I find it so useful.