Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix escapeing windows special chars #2652

Closed
wants to merge 1 commit into from
Closed

WIP fix escapeing windows special chars #2652

wants to merge 1 commit into from

Conversation

davisthedev
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context

Fixes #2446

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration

  • Tested on windows by navigating Telescope pickers and opening files to ensure special characters were escaped.

Configuration:

  • Neovim version (nvim --version): 0.9.1
  • Operating system and version: Windows 11

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

@jamestrew
Copy link
Contributor

@Conni2461 I'm thinking some of this probably belongs in plenary.path.

@davisthedev I'm also curious if using :set shellslash helps in any way in telescope.

@davisthedev
Copy link
Author

@jamestrew I did try :set shellslash before I started any dev work. It did not make a difference for telescope.

I would be happy to add this to plenary if that would help?
I am super new to lua and the neovim ecosystem so I may have some questions.

@jamestrew
Copy link
Contributor

Semi-related issue with plenary not gracefully handling windows paths set shellslash #2651

@jamestrew jamestrew self-assigned this Sep 6, 2023
@Conni2461
Copy link
Member

i think we should do that in plenary. And we already had a discussion about this in plenary

nvim-lua/plenary.nvim#254
nvim-lua/plenary.nvim#371

@jamestrew
Copy link
Contributor

The shellslash stuff looks very hairy to fix. I don't think I have the capacity/patience to fix it especially with this being a cross-platform/windows issue and I don't easily have a windows environment to test this kind of stuff.

And I believer when we're looking to eventually deprecate plenary and possibly rely more on neovim core of path stuff.

@davisthedev davisthedev closed this by deleting the head repository Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to preview and open files with parentheses in the path
3 participants