Link all default highlight groups to existing ones by default #553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The current default highlights in
define_highlights()are set to specific colors. This works well with thedefaulttheme in dark mode, but not so much in light mode. The same may be true for other themes that do not define theNeotest*highlight groups. The Cyan, Yellow, and Green colors (or their hex counterparts) were especially difficult to see for me (I'm colorblind, which probably makes the matter worse).This PR simply changes the default highlights to existing highlight groups, instead of specific colors.This should make the colors more consistent and accessible for most colorschemes. It does for the default one, which I have tested. I tried to keep the new colors as close as possible to the old ones. An alternative fix would be for users to handle this in the
highlightsconfig, but this would override the groups for colorschemes that do set theNeotest*groups.The second commit changes the
vim.cmdto separetevim.api.nvim_set_hlcalls. Let me know if you would prefer that I revert this.Thank you!
Fixes #310