fix(consumers/run): check spec.strategy before run #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OddBloke could this PR be reviewed |
rcarriga
requested changes
Aug 18, 2025
| local async_runners = {} | ||
| for _, spec in ipairs(specs) do | ||
| if not (type(spec.strategy) == "function" or type(spec.strategy) == "table" or spec.strategy == nil) then | ||
| self:_run_broken_down_tree(tree, args, adapter_id, adapter, results_callback) |
There was a problem hiding this comment.
Let's just raise the error directly here, it's not clear that this is being called just to raise an error
| code = instance.result() | ||
| end) | ||
| if not instance then | ||
| error("Adapter doesn't provide a correct strategy") |
There was a problem hiding this comment.
Please keep the original wording of the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is to check the type of
spec.strategybefore the async runners. Before this patch, when an adapter provider does not return the correct type ofspec.stragegy, neotest will raise the exception below:NOTE the error after the second argument: expected table, got string. That error comes from the code:
After this patch, the user will see a better error tip:
related commit: mrcjkb/rustaceanvim#803
After the above rustaceanvim fix, neotest gets:
This new error tip results in the second commit.
And finally, we get: