-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add build/test dependencies to rocks.lock #407
Conversation
8f11ae3
to
635ffb7
Compare
todo:
|
635ffb7
to
1c89b21
Compare
No idea why the integration tests are failing on Ubuntu 🥲 Perhaps we should do it like luarocks and only install test dependencies when running tests. That would mean you have to declare a dependency both in the regular dependencies and in the test dependencies if you want to use them in tests. |
Not sure I understand the following:
If they're in the test dependencies then that means you want to use them in tests, right? :p |
The question is, do you want to be able to |
e1d3c8a
to
dd33cee
Compare
Okay now it looks like it might be luarocks.org having issues. |
8ff119c
to
7877812
Compare
Ha! I figured it out. |
Yep, if you're testing functionality, and the regular dependencies are part of the functionality, then you definitely want them included too :p |
3b238b4
to
8f09984
Compare
7877812
to
7db6da5
Compare
7db6da5
to
c269f7a
Compare
8f09984
to
bddea78
Compare
Stacked on #405
Closes #395.