Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add build/test dependencies to rocks.lock #395

Open
mrcjkb opened this issue Feb 4, 2025 · 0 comments · Fixed by #407
Open

[Feature] add build/test dependencies to rocks.lock #395

mrcjkb opened this issue Feb 4, 2025 · 0 comments · Fixed by #407
Assignees
Labels
enhancement New feature or request

Comments

@mrcjkb
Copy link
Member

mrcjkb commented Feb 4, 2025

The project lockfile should probably include build/test dependencies.
This makes me think we might want to introduce a type like:

struct RocksLock<P: LockfilePermissions> {
  tree: DepsLock,
  test_tree: Option<DepsLock>,
  build_tree: Option<DepsLock>,
}

where DepsLock is equivalent to the current Lockfile struct, but without the filepath fields.

@mrcjkb mrcjkb added the enhancement New feature or request label Feb 4, 2025
@mrcjkb mrcjkb self-assigned this Feb 4, 2025
@mrcjkb mrcjkb linked a pull request Feb 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant