fix(container): truncate text by cell width/characters #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in lua, any number is truthy, and sub works just fine on 0-length strings so I don't think this does anything
|
Tried basic file names in cyrillic on your branch. Seems great 👍 . Fading also works (though differs from ascii names, but thats minor imho). I'll keep this version just for background testing, since i don't have enough time to create more elaborate test cases (and i dont know how to properly regress test neo-tree anyways). I'll comment if something weird comes up, otherwise would be nice to merge ) 
|
Oh yeah np, just wanted to make sure it helped with your issue. if anything i should be making test cases. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1619.
Current neo-tree behavior:
With this PR:
remaining issues (for future PRs?):
Also idk if this is an issue with this PR or neo-tree (might just be exacerbated due to the more intensive truncation), but changing the width repeatedly, really quickly, seems to cause the neo-tree window to scroll horizontally?
tagging @Emptyfruit if they'd like to test this out.