fix(filesystem): ignore dotfiles properly for find filter

[obukhovaa]

Not sure what was the purpose of that exclusion, but it was causing issues when find command is used within filter logic.

if not ignore.dotfiles then
  append("-not", "-path", "*/.*")
end

You would expect that when ignore-dotfiles is false you don't want to exclude dot files and directories. In fact it was not just excluding dot files, but all the other valid options if current path contains any . directories. For example for me the resulting command was

find  "/Users/nouwa/.config/nvim" -not -path '*/.*' -iname "*lua*"

and because my path has .config -- all files were excluded, producing empty search result.

Once this section removed, eveyrhing works as expected with both ignore.dotfiles = true and false.

[obukhovaa]

Still an issue #1459, would be nice to move it forward

[cseickel]

Sorry, I can't properly evaluate this. See #1606

[pynappo]

I agree that it's obviously breaking but I don't know if it's necessarily redundant. Based on the code for fd, the intention seems to be to optionally exclude hidden folders and hopefully reduce the amount of lines from the external cmd that neo-tree has to process?

To get the same functionality as the 'fd' block, could you try this instead? seems to work on my end:

    -- right after `for k, v in pairs(types) do ... end`
    if ignore.dotfiles then
      append("-name", ".*", "-prune", "-o")
    end

    -- right before the call to append_find_args:
    -- explicitly print out entries since `-prune -o` may expect an expression after it
    append("-print")

[obukhovaa]

Indeed, I've tested with both enabled/disabled setting, works well so far

[obukhovaa]

I've pushed the suggested improvement on top of the original fix, tested a few direct cases, didn't find any issues so far, so I think we good.