Report the update of the selection when using Word selection extend / reduce commmands (f8
or shift+f8
)
#17424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Partially fixes #3293.
Summary of the issue:
When using
f8
(extend selection) orshift+f8
(reduce selection) in Word, the selection changes are not reported.Description of user facing changes
When using
f8
(extend selection) orshift+f8
(reduce selection) in Word, the selection changes will now be reported.If the selection is extended / reduced at both ends, two consecutive selection update messages are reported, as done for
control+a
(select all).Description of development approach
In
WordDocument.initOverlayClass
, bindscript_caret_changeSelection
tof8
andshift+f8
, as already done for other gestures such asalt+shift+home
oralt+shift+pageDown
.Testing strategy:
Manual test of
f8
andshift+f8
in Word and Outlook, with and without UIA.Test made on Windows 10, Word 2016 (Microsoft® Word 2016 MSO (Version 2410 Build 16.0.18129.20158) 32 bits).
Known issues with pull request:
This PR only reports selection change when
f8
/shift+f8
is pressed.Though this PR does not fix the following issues:
F8
or when pressingescape
is not reported.Since these issues were pre-existing to this PR, my opinion is that this PR is already an improvement of the "extend selection mode" usage with respect to what was occurring before.
Code Review Checklist:
@coderabbitai summary