Update VSCode settings #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanbudd
reviewed
May 22, 2025
| @@ -233,9 +233,6 @@ | |||
| "中文", | |||
| "日本語" | |||
| ], | |||
| "flake8.args": [ | |||
| "--max-line-length=130", | |||
| ], | |||
| "git.ignoreLimitWarning": true, | |||
| "python.analysis.typeCheckingMode": "basic", | |||
There was a problem hiding this comment.
It seems like the python.analysis settings duplicate pyright settings in pyproject.toml. can you confirm?
There was a problem hiding this comment.
Yes, that seems to be the case. I think the only duplicated settings are the exclude directories, though. Do you agree?
seanbudd
reviewed
May 22, 2025
| "python.analysis.useLibraryCodeForTypes": true, | ||
|
|
||
| "python.defaultInterpreterPath": "${workspaceFolder}/.venv/bin/python", |
There was a problem hiding this comment.
If we're encouraging a .venv it might be worth adding some notes in documentation somewhere such as the readme on setting up the .venv and pre-commit
There was a problem hiding this comment.
Good idea - I'll open another PR with additions to the readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
.vscode/settings.jsonfile to reflect the changes we have made to linting and typechecking.