fix(Slider): add aria-label to thumb #5313
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
I've added a generic aria-label to the
SliderThumb.This is not the best solution and I'm open to suggestions on how to best handle this. The aria-label should be customizable on a case by case basis so we should also add a prop to handle this or bind the related attributes from $attrs.
The best case scenario is exposing and option to the user to pass in a function/object/array that will return the label for each thumb as the requirements of a11y change between single and multiple thumbs.
π Checklist