Skip to content

Conversation

@hywax
Copy link
Member

@hywax hywax commented Oct 24, 2025

πŸ”— Linked issue

Resolves #3089
Closes #3969

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

image image

TimeField, to have an option to create a time field instead of setting input type time.
Uses: https://reka-ui.com/docs/components/time-field as I saw usage of this in other components.

Also based styling and attributes based on the UInput

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 24, 2025

npm i https://pkg.pr.new/@nuxt/ui@5302

commit: 1666d70

@benjamincanac benjamincanac force-pushed the v4 branch 2 times, most recently from 60e4da6 to dc8040f Compare October 29, 2025 13:30
@hywax hywax marked this pull request as ready for review November 1, 2025 13:14
@hywax hywax requested a review from benjamincanac as a code owner November 1, 2025 13:14
@hywax
Copy link
Member Author

hywax commented Nov 1, 2025

@benjamincanac, you can take a look, there are two issues:

  1. I think I did everything right with CSS, but there is no space between :, I don't know if it's needed.
  2. It's not very clear how placeholder works. Even the documentation doesn't say anything about it. But I added props.

Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
@benjamincanac benjamincanac mentioned this pull request Nov 3, 2025
8 tasks
@benjamincanac
Copy link
Member

@hywax I cleaned the theme a bit as there was duplication with input.ts. However, do we really need this root div? I feel like the <TimeFieldRoot> should have ui.root() no? πŸ€”

@hywax
Copy link
Member Author

hywax commented Nov 4, 2025

I think it can be removed, I'll do it tomorrow.

@benjamincanac
Copy link
Member

benjamincanac commented Nov 5, 2025

@hywax So what I did is remove the Primitive (which was useless here since there is already flex on base) and the root slot to only use base and updated the theme:

  • removed root slot
  • removed inherited class on base slot
  • improve segment focus in different variants
  • cleaned segment slot classes (data-focused doesn't exist: https://reka-ui.com/docs/components/time-field#input)
  • added a smaller gap than input for each size instead of relying on important

Let me know what you think!

@hywax
Copy link
Member Author

hywax commented Nov 5, 2025

@benjamincanac thank you very much! I will use your efforts in #5387

hywax and others added 2 commits November 5, 2025 17:43
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[InputTime] Implement component

2 participants