feat(UProgress): add circular variant #4120
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Achraf931
changed the title
| @@ -71,6 +85,22 @@ props: | |||
| --- | |||
| :: | |||
|
|
|||
| ### Status Position | |||
|
|
|||
| Use the `statusPosition` prop to define where the status text is displayed. Defaults to `outside`. | |||
There was a problem hiding this comment.
Suggested change
| Use the `statusPosition` prop to define where the status text is displayed. Defaults to `outside`. | |
| Use the `status-position` prop to define where the status text is displayed. Defaults to `outside`. |
| @@ -109,6 +139,25 @@ props: | |||
| --- | |||
| :: | |||
|
|
|||
| ### Variant | |||
There was a problem hiding this comment.
You've added Variant twice.
| @@ -746,6 +746,7 @@ This is how the `@theme` is generated for each design token: | |||
| --outline-color-default: var(--ui-border); | |||
| --outline-color-inverted: var(--ui-border-inverted); | |||
| --stroke-color-default: var(--ui-border); | |||
There was a problem hiding this comment.
If you need this one, let's add them all for stroke and fill. So you can add --stroke-color-muted, --fill-color-muted and --fill-color-accented I guess.
added 2 commits
May 14, 2025 12:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ feat(UProgress): add circular variant and statusPosition props
🔗 Linked issue
Resolves #3728
❓ Type of change
📚 Description
This PR introduces:
circularvariant for theUProgresscomponent, allowing a circular visual representation of progress.statusPositionprop with the following options:"inside": displays the status (label or percent) in the center of the circle"outside": displays the status outside the circular progress (similar to the linear variant)These changes provide more flexibility for visualizing progress in various use cases.
📝 Checklist