ci: fail when generated registry types drift - #915
Conversation
PR #907 changed a component JSDoc without regenerating registry-types.json. Main shipped a stale file that the docs read, and later pnpm runs left checkouts dirty. The lint job now regenerates the file and fails on any diff.
|
Checked by hand, since CI on this PR only shows the green path:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe CI lint job now runs Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The lint job now catches stale generated registry types before they are merged, with no actionable merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📦 Package Size✅ No notable size changes 📚 22 runtime dependencies (no change) All tracked output (25)
Runtime dependencies (22)
Baseline: main_@_713ebe0f___2026-09-16 · gzip is the comparison metric · changes below 16 B gzip are ignored |
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. 3288e7db-7bf9-4188-ae6b-5b249e10d384 |
📚 Description
#907 changed a component JSDoc and merged without running
pnpm generate:types. The docs tables read the committedregistry-types.json, so they went stale. Every laterpnpmrun regenerated the file and left checkouts dirty, until another PR regenerated it by accident.The
lintjob now regenerates the file after install and fails on any diff:Heads-up: open PRs that change component props, emits, slots, or registry schemas may now fail this step, for example
feat/maplibre-bounds-cluster-options. The fix ispnpm generate:typesand a commit.