-
Notifications
You must be signed in to change notification settings - Fork 8
feat: ref/reactive outside vue/nuxtApp context detection #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huang-julien
wants to merge
5
commits into
main
Choose a base branch
from
feat/ssr_ref
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+35
β1
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cea65ee
feat: add outside vue/nuxt context usage detection of ref/reactive
huang-julien 2018617
perf: import.meta flag
huang-julien 84392f3
feat: log as error
huang-julien c6323da
Merge branch 'main' into feat/ssr_ref
huang-julien bfc471e
fix: change woding
huang-julien File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import { defineNuxtPlugin, ref } from '#imports' | ||
|
|
||
| ref('memory-leak-warning-shown') | ||
|
|
||
| export default defineNuxtPlugin(() => { | ||
| // Show memory leak warning | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { ref as _ref, reactive as _reactive, shallowReactive as _shallowReactive, shallowRef as _shallowRef, getCurrentInstance } from 'vue' | ||
| import { tryUseNuxtApp } from '#app' | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| function wrapWithWarning<Fn extends (...args: any[]) => any>(fn: Fn, name: string): Fn { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| return function (this: unknown, ...args: any[]) { | ||
| const nuxtApp = tryUseNuxtApp() | ||
| if (!nuxtApp && !getCurrentInstance()) { | ||
| console.error(new Error(`[@nuxt/hints] ${name}() called outside of setup() or without Nuxt app context. This may lead to Server side memory leaks or data leaks across requests.`)) | ||
| } | ||
| return fn.call(this, ...args) | ||
| } as Fn | ||
| } | ||
|
|
||
| export const ref = import.meta.server ? wrapWithWarning(_ref, 'ref') : _ref | ||
| export const reactive = import.meta.server ? wrapWithWarning(_reactive, 'reactive') : _reactive | ||
| export const shallowReactive = import.meta.server ? wrapWithWarning(_shallowReactive, 'shallowReactive') : _shallowReactive | ||
| export const shallowRef = import.meta.server ? wrapWithWarning(_shallowRef, 'shallowRef') : _shallowRef |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.